obsidian-plugin/quorafind_Obsidian-Float-Search
1
0
Fork 0
mirror of https://github.com/quorafind/Obsidian-Float-Search.git synced 2026-07-22 07:30:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: block search during IME composition to prevent premature queries

Browse source 
- FloatSearchModal.initInput: skip keyboard navigation during IME composition
  (check e.isComposing, e.key === 'Process', e.keyCode === 229)
- FloatSearchCmdkModal: set isComposing flag on compositionstart, clear it
  and trigger updateSuggestions on compositionend
- FloatSearchCmdkModal.updateSuggestions: bail out early if isComposing

Fixes the bug where typing Chinese pinyin (e.g. 'ka'pai' for '卡牌')
triggers search on every keystroke instead of waiting for the composed
character to be committed.
This commit is contained in:
artanis 2026-06-03 09:19:28 +08:00
parent 16fcf917a6
commit 9a944ca181
1 changed files with 13 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/floatSearchIndex.ts
View file

@ -1629,6 +1629,9 @@ class FloatSearchModal extends Modal {
}
inputEl.focus();
inputEl.onkeydown = (e) => {
if (e.isComposing || e.key === "Process" || e.keyCode === 229) {
return;
}
const currentView = this.searchLeaf.view as SearchView;
switch (e.key) {
case "ArrowDown":
@ -1961,6 +1964,7 @@ interface CmdkResult {
class FloatSearchCmdkModal extends SuggestModal<CmdkResult> {
plugin: FloatSearchPlugin;
private bodyEl: HTMLElement;
private isComposing = false;
private previewEl: HTMLElement | undefined;
private fileLeaf: WorkspaceLeaf | undefined;
private fileEmbeddedView: EmbeddedView | undefined;
@ -1983,6 +1987,14 @@ class FloatSearchCmdkModal extends SuggestModal<CmdkResult> {
onOpen() {
super.onOpen();
this.isComposing = false;
this.inputEl.addEventListener("compositionstart", () => {
this.isComposing = true;
});
this.inputEl.addEventListener("compositionend", () => {
this.isComposing = false;
this.updateSuggestions();
});
this.bodyEl = createDiv("float-search-cmdk-body");
this.modalEl.insertBefore(
this.bodyEl,
@ -1998,6 +2010,7 @@ class FloatSearchCmdkModal extends SuggestModal<CmdkResult> {
// Override to use progressive rendering via chooser.addSuggestion
updateSuggestions() {
if (this.isComposing) return;
// Cancel previous in-flight search
this.searchAbort?.abort();
const abort = (this.searchAbort = new AbortController());