mirror of
https://github.com/scotttomaszewski/obsidian-disciples-journal.git
synced 2026-07-22 05:42:13 +00:00
Cleanup
This commit is contained in:
Scott Tomaszewski
parent
82005ef582
commit
6845d37544
6 changed files with 168 additions and 70 deletions
19
FOLLOWUPS.md
19
FOLLOWUPS.md
|
|
@ -16,25 +16,6 @@ Each entry should include:
|
|||
|
||||
---
|
||||
|
||||
## Remove (or wire up) dead `BibleCodeblockFormatter`
|
||||
|
||||
- **Identified:** 2026-05-31, funky-logic sweep while documenting the repo.
|
||||
- **What:** `src/utils/BibleCodeblockFormatter.ts` has no callers and carries a
|
||||
`// TODO - this probably belongs somewhere else`. Decide: delete it, or use it.
|
||||
- **Why:** Dead code misleads the next agent into thinking it's part of the flow.
|
||||
- **Context:** Confirmed unused via `grep -rn BibleCodeblockFormatter src/`.
|
||||
- **Effort:** XS
|
||||
|
||||
## Remove vestigial `ESV` / `ESVVerse` globals
|
||||
|
||||
- **Identified:** 2026-05-31, funky-logic sweep.
|
||||
- **What:** `src/types.d.ts` declares `interface ESVVerse` and
|
||||
`declare const ESV: ESVVerse[]`. The `ESV` global appears unused at runtime —
|
||||
verify, then drop the declaration if so.
|
||||
- **Why:** A declared global with no backing implementation is a trap.
|
||||
- **Context:** Only the declaration shows up in `src/`; confirm no consumer before removing.
|
||||
- **Effort:** XS
|
||||
|
||||
## Add a test harness, starting with `BibleReference.parse`
|
||||
|
||||
- **Identified:** 2026-05-31, repo documentation pass.
|
||||
|
|
|
|||
42
devbox.json
42
devbox.json
|
|
@ -1,15 +1,31 @@
|
|||
{
|
||||
"$schema": "https://raw.githubusercontent.com/jetify-com/devbox/0.16.0/.schema/devbox.schema.json",
|
||||
"packages": [
|
||||
"github-cli@latest",
|
||||
"jq@latest"
|
||||
],
|
||||
"shell": {
|
||||
"init_hook": [
|
||||
"echo 'Welcome to devbox!' > /dev/null"
|
||||
],
|
||||
"scripts": {
|
||||
"release": "just release $@"
|
||||
}
|
||||
}
|
||||
"$schema": "https://raw.githubusercontent.com/jetify-com/devbox/0.17.2/.schema/devbox.schema.json",
|
||||
"packages": [
|
||||
"nodejs@22",
|
||||
"just@latest",
|
||||
"github-cli@latest",
|
||||
"jq@latest"
|
||||
],
|
||||
"shell": {
|
||||
"init_hook": [
|
||||
"npm install --no-audit --no-fund"
|
||||
],
|
||||
"scripts": {
|
||||
"build": [
|
||||
"npm run build"
|
||||
],
|
||||
"dev": [
|
||||
"npm run dev"
|
||||
],
|
||||
"test": [
|
||||
"npm run test"
|
||||
],
|
||||
"release": [
|
||||
"just release $@"
|
||||
],
|
||||
"run": [
|
||||
"$@"
|
||||
]
|
||||
}
|
||||
}
|
||||
}
|
||||
|
|
|
|||
137
devbox.lock
137
devbox.lock
|
|
@ -7,6 +7,10 @@
|
|||
"source": "devbox-search",
|
||||
"version": "2.23.0"
|
||||
},
|
||||
"github:NixOS/nixpkgs/nixpkgs-unstable": {
|
||||
"last_modified": "2026-05-29T05:01:12Z",
|
||||
"resolved": "github:NixOS/nixpkgs/e9a7635a57597d9754eccebdfc7045e6c8600e6b?lastModified=1780030872&narHash=sha256-u6WU%2Fyd%2Fo8iYQrHX3RAwO1hYa3LkoSL%2BWNQD0rJfJZQ%3D"
|
||||
},
|
||||
"jq@latest": {
|
||||
"last_modified": "2026-03-16T02:27:38Z",
|
||||
"resolved": "github:NixOS/nixpkgs/f8573b9c935cfaa162dd62cc9e75ae2db86f85df#jq",
|
||||
|
|
@ -122,6 +126,139 @@
|
|||
"store_path": "/nix/store/jyi1vkcbaihqbfbra4qd0107sj1jhdk4-jq-1.8.1-bin"
|
||||
}
|
||||
}
|
||||
},
|
||||
"just@latest": {
|
||||
"last_modified": "2026-05-21T08:15:18Z",
|
||||
"resolved": "github:NixOS/nixpkgs/4a29d733e8a7d5b824c3d8c958a946a9867b3eb2#just",
|
||||
"source": "devbox-search",
|
||||
"version": "1.51.0",
|
||||
"systems": {
|
||||
"aarch64-darwin": {
|
||||
"outputs": [
|
||||
{
|
||||
"name": "out",
|
||||
"path": "/nix/store/18ml04rix1526kmcv5fcir6n7cb8lxyf-just-1.51.0",
|
||||
"default": true
|
||||
},
|
||||
{
|
||||
"name": "man",
|
||||
"path": "/nix/store/48iac05gjz4kjpx605hcgn95an8ary9q-just-1.51.0-man",
|
||||
"default": true
|
||||
},
|
||||
{
|
||||
"name": "doc",
|
||||
"path": "/nix/store/d0n7b7xd2miyja6m2nlzc2szj0gqzgxb-just-1.51.0-doc"
|
||||
}
|
||||
],
|
||||
"store_path": "/nix/store/18ml04rix1526kmcv5fcir6n7cb8lxyf-just-1.51.0"
|
||||
},
|
||||
"aarch64-linux": {
|
||||
"outputs": [
|
||||
{
|
||||
"name": "out",
|
||||
"path": "/nix/store/6q8i59br2gzxnqax4dz3g1fmkwp2mfs2-just-1.51.0",
|
||||
"default": true
|
||||
},
|
||||
{
|
||||
"name": "man",
|
||||
"path": "/nix/store/8ygmlmpxmggc2wqbkz1yhf7fz5nwg084-just-1.51.0-man",
|
||||
"default": true
|
||||
},
|
||||
{
|
||||
"name": "doc",
|
||||
"path": "/nix/store/ppj3c78k6x3bql77f3mgrjjrxb2jjc0q-just-1.51.0-doc"
|
||||
}
|
||||
],
|
||||
"store_path": "/nix/store/6q8i59br2gzxnqax4dz3g1fmkwp2mfs2-just-1.51.0"
|
||||
},
|
||||
"x86_64-darwin": {
|
||||
"outputs": [
|
||||
{
|
||||
"name": "out",
|
||||
"path": "/nix/store/7ppiil9ycr565vqgbc18x4rpgbfgcnzy-just-1.51.0",
|
||||
"default": true
|
||||
},
|
||||
{
|
||||
"name": "man",
|
||||
"path": "/nix/store/144wqvh3s441y05xvzn8m16rhcqbki7d-just-1.51.0-man",
|
||||
"default": true
|
||||
},
|
||||
{
|
||||
"name": "doc",
|
||||
"path": "/nix/store/x5g644hwbjdlij9w37gwgg1z1h4b6qqk-just-1.51.0-doc"
|
||||
}
|
||||
],
|
||||
"store_path": "/nix/store/7ppiil9ycr565vqgbc18x4rpgbfgcnzy-just-1.51.0"
|
||||
},
|
||||
"x86_64-linux": {
|
||||
"outputs": [
|
||||
{
|
||||
"name": "out",
|
||||
"path": "/nix/store/3j32zmchv9wd60qng1mm04yj07wf04i8-just-1.51.0",
|
||||
"default": true
|
||||
},
|
||||
{
|
||||
"name": "man",
|
||||
"path": "/nix/store/p04vig0h2hj7hg5vgd74n5nphlcy23l8-just-1.51.0-man",
|
||||
"default": true
|
||||
},
|
||||
{
|
||||
"name": "doc",
|
||||
"path": "/nix/store/r800x8xppg70s00hw3h6x9cxpd6nh06y-just-1.51.0-doc"
|
||||
}
|
||||
],
|
||||
"store_path": "/nix/store/3j32zmchv9wd60qng1mm04yj07wf04i8-just-1.51.0"
|
||||
}
|
||||
}
|
||||
},
|
||||
"nodejs@22": {
|
||||
"last_modified": "2026-05-21T08:15:18Z",
|
||||
"plugin_version": "0.0.2",
|
||||
"resolved": "github:NixOS/nixpkgs/4a29d733e8a7d5b824c3d8c958a946a9867b3eb2#nodejs_22",
|
||||
"source": "devbox-search",
|
||||
"version": "22.22.3",
|
||||
"systems": {
|
||||
"aarch64-darwin": {
|
||||
"outputs": [
|
||||
{
|
||||
"name": "out",
|
||||
"path": "/nix/store/k1yy2d1h7pvpac7m14vmaw23j529fpza-nodejs-22.22.3",
|
||||
"default": true
|
||||
}
|
||||
],
|
||||
"store_path": "/nix/store/k1yy2d1h7pvpac7m14vmaw23j529fpza-nodejs-22.22.3"
|
||||
},
|
||||
"aarch64-linux": {
|
||||
"outputs": [
|
||||
{
|
||||
"name": "out",
|
||||
"path": "/nix/store/d8zana2n6i904c088i533ivg1j817x8v-nodejs-22.22.3",
|
||||
"default": true
|
||||
}
|
||||
],
|
||||
"store_path": "/nix/store/d8zana2n6i904c088i533ivg1j817x8v-nodejs-22.22.3"
|
||||
},
|
||||
"x86_64-darwin": {
|
||||
"outputs": [
|
||||
{
|
||||
"name": "out",
|
||||
"path": "/nix/store/9yvmgryhhwnswgaji30cpw4m9swhv1ia-nodejs-22.22.3",
|
||||
"default": true
|
||||
}
|
||||
],
|
||||
"store_path": "/nix/store/9yvmgryhhwnswgaji30cpw4m9swhv1ia-nodejs-22.22.3"
|
||||
},
|
||||
"x86_64-linux": {
|
||||
"outputs": [
|
||||
{
|
||||
"name": "out",
|
||||
"path": "/nix/store/ac9bklddx1klg92hj7r08xmpky1nwag2-nodejs-22.22.3",
|
||||
"default": true
|
||||
}
|
||||
],
|
||||
"store_path": "/nix/store/ac9bklddx1klg92hj7r08xmpky1nwag2-nodejs-22.22.3"
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
|
|
|||
4
package-lock.json
generated
4
package-lock.json
generated
|
|
@ -1,12 +1,12 @@
|
|||
{
|
||||
"name": "obsidian-disciples-journal",
|
||||
"version": "0.12.0",
|
||||
"version": "0.13.1",
|
||||
"lockfileVersion": 3,
|
||||
"requires": true,
|
||||
"packages": {
|
||||
"": {
|
||||
"name": "obsidian-disciples-journal",
|
||||
"version": "0.12.0",
|
||||
"version": "0.13.1",
|
||||
"license": "MIT",
|
||||
"devDependencies": {
|
||||
"@codemirror/language": "^6.0.0",
|
||||
|
|
|
|||
13
src/types.d.ts
vendored
13
src/types.d.ts
vendored
|
|
@ -2,16 +2,3 @@ declare module '*.json' {
|
|||
const value: unknown;
|
||||
export default value;
|
||||
}
|
||||
|
||||
// Define the structure of the Bible data for better type checking
|
||||
interface ESVVerse {
|
||||
pk: number;
|
||||
translation: string;
|
||||
book: number | string;
|
||||
chapter: number;
|
||||
verse: number;
|
||||
text: string;
|
||||
comment?: string;
|
||||
}
|
||||
|
||||
declare const ESV: ESVVerse[];
|
||||
|
|
|
|||
|
|
@ -1,23 +0,0 @@
|
|||
import {BiblePassage} from "./BiblePassage";
|
||||
|
||||
/**
|
||||
* Utility for formatting Bible content consistently across the application
|
||||
*/
|
||||
// TODO - this probably belongs somewhere else
|
||||
export class BibleCodeblockFormatter {
|
||||
/**
|
||||
* Format chapter content as Markdown
|
||||
*/
|
||||
public static formatChapterContent(passage: BiblePassage): string {
|
||||
if (!passage) return "# Error: No passage content\n\nThe requested passage could not be loaded.";
|
||||
|
||||
let content = "";
|
||||
|
||||
// Add code block for rendering
|
||||
content += "```bible\n";
|
||||
content += passage.reference.toString();
|
||||
content += "\n```\n\n";
|
||||
|
||||
return content;
|
||||
}
|
||||
}
|
||||
Loading…
Reference in a new issue