From 286c8992be0c6543b4c85fd1868ab2dc84e5a23b Mon Sep 17 00:00:00 2001 From: touss59 Date: Wed, 15 Jul 2026 23:36:59 +0200 Subject: [PATCH] fix review risks --- package-lock.json | 63 ++++++++++++++++++++++++++++------------------- package.json | 8 +++--- src/settings.ts | 4 +-- 3 files changed, 43 insertions(+), 32 deletions(-) diff --git a/package-lock.json b/package-lock.json index 2d23bc6..5d3d5cf 100644 --- a/package-lock.json +++ b/package-lock.json @@ -12,15 +12,15 @@ "@codesandbox/sandpack-client": "^2.19.8", "@codesandbox/sandpack-react": "^2.20.0", "@codesandbox/sandpack-themes": "^2.0.21", - "react": "^19.2.3", - "react-dom": "^19.2.3" + "react": "^18.3.1", + "react-dom": "^18.3.1" }, "devDependencies": { "@eslint/js": "9.30.1", "@testing-library/react": "^16.1.0", "@types/node": "^20", - "@types/react": "^19.2.8", - "@types/react-dom": "^19.2.3", + "@types/react": "^18.3.31", + "@types/react-dom": "^18.3.7", "esbuild": "0.25.5", "eslint": "^9.30.1", "eslint-plugin-obsidianmd": "0.1.9", @@ -1599,24 +1599,32 @@ "dev": true, "license": "MIT" }, + "node_modules/@types/prop-types": { + "version": "15.7.15", + "resolved": "https://registry.npmjs.org/@types/prop-types/-/prop-types-15.7.15.tgz", + "integrity": "sha512-F6bEyamV9jKGAFBEmlQnesRPGOQqS2+Uwi0Em15xenOxHaf2hv6L8YCVn3rPdPJOiJfPiCnLIRyvwVaqMY3MIw==", + "dev": true, + "license": "MIT" + }, "node_modules/@types/react": { - "version": "19.2.8", - "resolved": "https://registry.npmjs.org/@types/react/-/react-19.2.8.tgz", - "integrity": "sha512-3MbSL37jEchWZz2p2mjntRZtPt837ij10ApxKfgmXCTuHWagYg7iA5bqPw6C8BMPfwidlvfPI/fxOc42HLhcyg==", + "version": "18.3.31", + "resolved": "https://registry.npmjs.org/@types/react/-/react-18.3.31.tgz", + "integrity": "sha512-vfEqpXTvwT91yhmwdfouStN2hSKwTvyRs8qpLfADyrq/kxDw0hZM7Wk9Ug1FELj8hIby+S/+kQCSRFF32nv2Qw==", "dev": true, "license": "MIT", "dependencies": { + "@types/prop-types": "*", "csstype": "^3.2.2" } }, "node_modules/@types/react-dom": { - "version": "19.2.3", - "resolved": "https://registry.npmjs.org/@types/react-dom/-/react-dom-19.2.3.tgz", - "integrity": "sha512-jp2L/eY6fn+KgVVQAOqYItbF0VY/YApe5Mz2F0aykSO8gx31bYCZyvSeYxCHKvzHG5eZjc+zyaS5BrBWya2+kQ==", + "version": "18.3.7", + "resolved": "https://registry.npmjs.org/@types/react-dom/-/react-dom-18.3.7.tgz", + "integrity": "sha512-MEe3UeoENYVFXzoXEWsvcpg6ZvlrFNlOQ7EOsvhI3CfAXwzPfO8Qwuxd40nepsYKqyyVQnTdEfv68q91yLcKrQ==", "dev": true, "license": "MIT", "peerDependencies": { - "@types/react": "^19.2.0" + "@types/react": "^18.0.0" } }, "node_modules/@types/tern": { @@ -4723,7 +4731,6 @@ "version": "4.0.0", "resolved": "https://registry.npmjs.org/js-tokens/-/js-tokens-4.0.0.tgz", "integrity": "sha512-RdJUflcE3cUzKiMqQgsCu06FPu9UdIJO0beYbPhHN4k6apgJtifcoCtT9bcxOpYBtpD2kCM6Sbzg4CausW/PKQ==", - "dev": true, "license": "MIT" }, "node_modules/js-yaml": { @@ -5220,7 +5227,6 @@ "version": "1.4.0", "resolved": "https://registry.npmjs.org/loose-envify/-/loose-envify-1.4.0.tgz", "integrity": "sha512-lyuxPGr/Wfhrlem2CL/UcnUc1zcqKAImBDzukY7Y5F/yQiNdko6+fRLevlw1HgMySw7f611UIY408EtxRSoK3Q==", - "dev": true, "license": "MIT", "dependencies": { "js-tokens": "^3.0.0 || ^4.0.0" @@ -5794,10 +5800,13 @@ "license": "MIT" }, "node_modules/react": { - "version": "19.2.3", - "resolved": "https://registry.npmjs.org/react/-/react-19.2.3.tgz", - "integrity": "sha512-Ku/hhYbVjOQnXDZFv2+RibmLFGwFdeeKHFcOTlrt7xplBnya5OGn/hIRDsqDiSUcfORsDC7MPxwork8jBwsIWA==", + "version": "18.3.1", + "resolved": "https://registry.npmjs.org/react/-/react-18.3.1.tgz", + "integrity": "sha512-wS+hAgJShR0KhEvPJArfuPVN1+Hz1t0Y6n5jLrGQbkb4urgPE/0Rve+1kMB1v/oWgHgm4WIcV+i7F2pTVj+2iQ==", "license": "MIT", + "dependencies": { + "loose-envify": "^1.1.0" + }, "engines": { "node": ">=0.10.0" } @@ -5812,15 +5821,16 @@ } }, "node_modules/react-dom": { - "version": "19.2.3", - "resolved": "https://registry.npmjs.org/react-dom/-/react-dom-19.2.3.tgz", - "integrity": "sha512-yELu4WmLPw5Mr/lmeEpox5rw3RETacE++JgHqQzd2dg+YbJuat3jH4ingc+WPZhxaoFzdv9y33G+F7Nl5O0GBg==", + "version": "18.3.1", + "resolved": "https://registry.npmjs.org/react-dom/-/react-dom-18.3.1.tgz", + "integrity": "sha512-5m4nQKp+rZRb09LNH59GM4BxTh9251/ylbKIbpe7TpGxfJ+9kv6BLkLBXIjjspbgbnIBNqlI23tRnTWT0snUIw==", "license": "MIT", "dependencies": { - "scheduler": "^0.27.0" + "loose-envify": "^1.1.0", + "scheduler": "^0.23.2" }, "peerDependencies": { - "react": "^19.2.3" + "react": "^18.3.1" } }, "node_modules/react-is": { @@ -6101,10 +6111,13 @@ } }, "node_modules/scheduler": { - "version": "0.27.0", - "resolved": "https://registry.npmjs.org/scheduler/-/scheduler-0.27.0.tgz", - "integrity": "sha512-eNv+WrVbKu1f3vbYJT/xtiF5syA5HPIMtf9IgY/nKg0sWqzAUEvqY/xm7OcZc/qafLx/iO9FgOmeSAp4v5ti/Q==", - "license": "MIT" + "version": "0.23.2", + "resolved": "https://registry.npmjs.org/scheduler/-/scheduler-0.23.2.tgz", + "integrity": "sha512-UOShsPwz7NrMUqhR6t0hWjFduvOzbtv7toDH1/hIrfRNIDBnnBWd0CwJTGvTpngVlmwGCdP9/Zl/tVrDqcuYzQ==", + "license": "MIT", + "dependencies": { + "loose-envify": "^1.1.0" + } }, "node_modules/semver": { "version": "6.3.1", diff --git a/package.json b/package.json index 51790a5..77f6f6f 100644 --- a/package.json +++ b/package.json @@ -17,8 +17,8 @@ "@eslint/js": "9.30.1", "@testing-library/react": "^16.1.0", "@types/node": "^20", - "@types/react": "^19.2.8", - "@types/react-dom": "^19.2.3", + "@types/react": "^18.3.31", + "@types/react-dom": "^18.3.7", "esbuild": "0.25.5", "eslint": "^9.30.1", "eslint-plugin-obsidianmd": "0.1.9", @@ -35,7 +35,7 @@ "@codesandbox/sandpack-client": "^2.19.8", "@codesandbox/sandpack-react": "^2.20.0", "@codesandbox/sandpack-themes": "^2.0.21", - "react": "^19.2.3", - "react-dom": "^19.2.3" + "react": "^18.3.1", + "react-dom": "^18.3.1" } } diff --git a/src/settings.ts b/src/settings.ts index ac85630..f17d6f7 100644 --- a/src/settings.ts +++ b/src/settings.ts @@ -304,9 +304,7 @@ export class CodePlaygroundSettingTab extends PluginSettingTab { }); new Setting(containerEl) - // "CodeSandbox" is a brand name and keeps its capitalization. - // eslint-disable-next-line obsidianmd/ui/sentence-case - .setName("Show 'Open in CodeSandbox' button") + .setName("Show button to open in code sandbox") .addToggle((toggle) => toggle .setValue(this.plugin.settings.showOpenInCodeSandbox)