From d9df9ec22becbc5a608fdf9b6f77d729d3529b46 Mon Sep 17 00:00:00 2001 From: wz <44930227+wenlzhang@users.noreply.github.com> Date: Sat, 5 Apr 2025 10:56:24 +0200 Subject: [PATCH] Address review comments --- README.md | 2 +- manifest.json | 2 +- src/folderSuggestModal.ts | 16 ++-------------- 3 files changed, 4 insertions(+), 16 deletions(-) diff --git a/README.md b/README.md index 8850ee3..167c50d 100644 --- a/README.md +++ b/README.md @@ -1,4 +1,4 @@ -# Obsidian Folder Navigator +# Folder Navigator [![GitHub release (Latest by date)](https://img.shields.io/github/v/release/wenlzhang/obsidian-folder-navigator)](https://github.com/wenlzhang/obsidian-folder-navigator/releases) ![GitHub all releases](https://img.shields.io/github/downloads/wenlzhang/obsidian-folder-navigator/total?color=success) diff --git a/manifest.json b/manifest.json index 58564ce..1e3cc7e 100644 --- a/manifest.json +++ b/manifest.json @@ -2,7 +2,7 @@ "id": "folder-navigator", "name": "Folder Navigator", "version": "0.1.0", - "minAppVersion": "1.0.0", + "minAppVersion": "1.5.3", "description": "Quickly navigate to folders in your vault using fuzzy search.", "author": "wenlzhang", "authorUrl": "https://github.com/wenlzhang", diff --git a/src/folderSuggestModal.ts b/src/folderSuggestModal.ts index 6936176..c5f6202 100644 --- a/src/folderSuggestModal.ts +++ b/src/folderSuggestModal.ts @@ -30,20 +30,8 @@ export class FolderSuggestModal extends FuzzySuggestModal { } private getAllFolders(): TFolder[] { - const folders: TFolder[] = []; - const rootFolder = this.app.vault.getRoot(); - - const collectFolders = (folder: TFolder) => { - folders.push(folder); - folder.children.forEach((child) => { - if (child instanceof TFolder) { - collectFolders(child); - } - }); - }; - - collectFolders(rootFolder); - return folders; + // Use the official Vault.getAllFolders() API instead of custom implementation + return this.app.vault.getAllFolders(); } getItems(): TFolder[] {