obsidian-plugin/williamsjack_pairwise-glicko-ranking
1
0
Fork 0
mirror of https://github.com/williamsjack/pairwise-glicko-ranking.git synced 2026-07-22 06:44:09 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Round before rating comparisons for consistency with frontmatter

Browse source
This commit is contained in:
Jack Williams 2026-03-08 00:22:47 +11:00
parent 42bbe6b289
commit 62f3e349b2
1 changed files with 10 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/utils/FrontmatterStats.ts
View file

@ -26,7 +26,7 @@ function anyEnabled(fm: FrontmatterPropertiesSettings): boolean {
// Standard competition ranking ("1224" style)
export function computeRanksForAll(cohort: CohortData): Map<string, number> {
const entries = Object.entries(cohort.players);
entries.sort((a, b) => b[1].rating - a[1].rating);
entries.sort((a, b) => Math.round(b[1].rating) - Math.round(a[1].rating));
const map = new Map<string, number>();
let lastRating: number | undefined = undefined;
@ -35,9 +35,10 @@ export function computeRanksForAll(cohort: CohortData): Map<string, number> {
for (let i = 0; i < entries.length; i++) {
const [id, player] = entries[i];
if (lastRating === undefined || player.rating !== lastRating) {
const rounded = Math.round(player.rating);
if (lastRating === undefined || rounded !== lastRating) {
rank = nextRank;
lastRating = player.rating;
lastRating = rounded;
}
map.set(id, rank);
nextRank = i + 2;
@ -49,7 +50,10 @@ export function computeRanksForAll(cohort: CohortData): Map<string, number> {
// have a strictly higher rating (standard competition ranking)
function computeRanksForSubset(cohort: CohortData, playerIds: string[]): Map<string, number> {
const targets = playerIds
.map((id) => ({ id, rating: cohort.players[id]?.rating }))
.map((id) => {
const r = cohort.players[id]?.rating;
return { id, rating: r !== undefined ? Math.round(r) : undefined };
})
.filter((t): t is { id: string; rating: number } => t.rating !== undefined);
if (targets.length === 0) return new Map();
@ -58,8 +62,9 @@ function computeRanksForSubset(cohort: CohortData, playerIds: string[]): Map<str
// any target's rating and increment that target's rank counter
const higherCounts = new Map<string, number>(targets.map((t) => [t.id, 0]));
for (const player of Object.values(cohort.players)) {
const rounded = Math.round(player.rating);
for (const t of targets) {
if (player.rating > t.rating) {
if (rounded > t.rating) {
higherCounts.set(t.id, higherCounts.get(t.id)! + 1);
}
}