Merge pull request #1 from perinchiang/codex/fix-theme-review-warnings

Fix Obsidian theme review warnings

manifest.json

@@ -2,6 +2,5 @@
   "name": "Misty",
   "version": "1.0.3",
   "minAppVersion": "1.12.0",
-  "author": "Patrick",
-  "screenshot": "screenshot.png"
+  "author": "Patrick"
 }

theme.css

@@ -761,7 +761,7 @@ a.tag:hover {
 .menu,
 .suggestion-item,
 .status-bar {
-  font-family: var(--font-interface-theme) !important;
+  font-family: var(--font-interface-theme);
 }
 
 .markdown-preview-view,
@@ -769,7 +769,7 @@ a.tag:hover {
 .markdown-source-view.mod-cm6 .cm-scroller,
 .cm-line,
 .cm-editor {
-  font-family: var(--font-text-theme) !important;
+  font-family: var(--font-text-theme);
   line-height: 1.7;
 }
 
@@ -778,7 +778,7 @@ a.tag:hover {
 code,
 pre,
 .markdown-rendered code {
-  font-family: var(--font-monospace-theme) !important;
+  font-family: var(--font-monospace-theme);
 }
 
 .workspace {
@@ -800,7 +800,7 @@ pre,
 .workspace-split.mod-left-split .workspace-tab-container,
 .workspace-split.mod-left-split .workspace-leaf-content,
 .workspace-split.mod-left-split .nav-files-container {
-  background: transparent !important;
+  background: transparent;
 }
 
 .workspace-split.mod-left-split > .workspace-tabs {
@@ -859,7 +859,6 @@ body.mod-macos:not(.is-fullscreen):not(.is-mobile)
 }
 
 .workspace-split.mod-left-split .workspace-tab-header-container-inner {
-  --cp-segment-slider-x: 0;
   position: relative;
   width: 100%;
   height: 28px;
@@ -873,39 +872,8 @@ body.mod-macos:not(.is-fullscreen):not(.is-mobile)
   background: var(--cp-segment-bg);
 }
 
-.workspace-split.mod-left-split
-  .workspace-tab-header-container-inner:has(
-    > .workspace-tab-header[data-type="search"].is-active
-  ) {
-  --cp-segment-slider-x: calc(100% + 2px);
-}
-
-.workspace-split.mod-left-split
-  .workspace-tab-header-container-inner:has(
-    > .workspace-tab-header[data-type="bookmarks"].is-active
-  ) {
-  --cp-segment-slider-x: calc(200% + 4px);
-}
-
-.workspace-split.mod-left-split .workspace-tab-header-container-inner::before {
-  content: "";
-  position: absolute;
-  top: -1px;
-  bottom: -1px;
-  left: -1px;
-  width: calc((100% - 4px) / 3);
-  border: 0;
-  border-radius: 6px;
-  background: var(--cp-segment-active-bg, var(--cp-panel-bg));
-  box-shadow: none !important;
-  transform: translateX(var(--cp-segment-slider-x));
-  transition: transform 180ms cubic-bezier(0.22, 1, 0.36, 1);
-  pointer-events: none;
-}
-
 .workspace-split.mod-left-split .workspace-tab-header {
   position: relative;
-  z-index: 1;
   flex: 1 1 0;
   justify-content: center;
   min-width: 0;
@@ -915,22 +883,22 @@ body.mod-macos:not(.is-fullscreen):not(.is-mobile)
   border: 1px solid transparent;
   border-radius: 5px;
   color: var(--text-muted);
-  background: transparent !important;
-  box-shadow: none !important;
-  transition: color 120ms ease;
+  background: transparent;
+  box-shadow: none;
+  transition: background-color 120ms ease, color 120ms ease;
 }
 
 .workspace-split.mod-left-split .workspace-tab-header:hover {
   color: var(--text-normal);
-  background: transparent !important;
-  box-shadow: none !important;
+  background: transparent;
+  box-shadow: none;
 }
 
 .workspace-split.mod-left-split .workspace-tab-header.is-active {
   color: var(--text-normal);
   border-color: transparent;
-  background: transparent !important;
-  box-shadow: none !important;
+  background: var(--cp-segment-active-bg, var(--cp-panel-bg));
+  box-shadow: none;
 }
 
 .workspace-split.mod-left-split .workspace-tab-header-inner {
@@ -1002,7 +970,7 @@ body.mod-macos:not(.is-fullscreen):not(.is-mobile)
   font-weight: 500;
   letter-spacing: -0.01em;
   line-height: 1;
-  opacity: 1 !important;
+  opacity: 1;
 }
 
 .workspace-split.mod-left-split .workspace-tab-header-spacer,
@@ -1125,7 +1093,7 @@ body.mod-macos:not(.is-fullscreen):not(.is-mobile)
   .workspace:not(.is-left-sidedock-open)
   .mod-root
   .workspace-tab-header-container {
-  padding-left: 120px !important;
+  padding-left: 120px;
 }
 
 .workspace > .workspace-ribbon.mod-left.claude-ribbon-collapsed::before,
@@ -1145,9 +1113,9 @@ body.mod-macos:not(.is-fullscreen):not(.is-mobile)
 }
 
 .workspace-split.mod-left-split .workspace-sidedock-vault-profile {
-  order: 30 !important;
+  order: 30;
   border-top: 1px solid var(--cp-border-soft);
-  background: transparent !important;
+  background: transparent;
 }
 
 .workspace-split.mod-left-split .workspace-drawer-vault-switcher,
@@ -1191,9 +1159,9 @@ body.mod-macos:not(.is-fullscreen):not(.is-mobile)
 
 .metadata-container .metadata-property-key-input {
   color: var(--text-muted);
-  border: 0 !important;
-  background: transparent !important;
-  box-shadow: none !important;
+  border: 0;
+  background: transparent;
+  box-shadow: none;
 }
 
 .metadata-container .metadata-property-icon {
@@ -1214,17 +1182,17 @@ body.mod-macos:not(.is-fullscreen):not(.is-mobile)
 
 .mod-root .workspace-tab-header-container {
   border-bottom: 1px solid var(--cp-border-soft);
-  background-color: var(--background-primary) !important;
+  background-color: var(--background-primary);
   transition: padding-left 200ms ease;
 }
 
 .mod-root .workspace-tab-header-container .workspace-tab-header-container-inner {
-  background-color: var(--background-primary) !important;
+  background-color: var(--background-primary);
 }
 
 .mod-root.workspace-tabs,
 .mod-root .workspace-tab-container {
-  background-color: var(--background-primary) !important;
+  background-color: var(--background-primary);
 }
 
 .status-bar {
@@ -1286,11 +1254,11 @@ body.theme-light {
 .prompt-input-container input {
   min-height: 46px;
   box-sizing: border-box;
-  border: 0 !important;
-  border-radius: inherit !important;
-  background: transparent !important;
-  box-shadow: none !important;
-  outline: 0 !important;
+  border: 0;
+  border-radius: inherit;
+  background: transparent;
+  box-shadow: none;
+  outline: 0;
 }
 
 /* ============================================================