obsidian-plugin/aaronsb_obsidian-mcp-plugin

mirror of https://github.com/aaronsb/obsidian-mcp-plugin.git synced 2026-07-22 06:45:14 +00:00

Aaron Bockelie 69be0a007e fix(onboarding): restore one-command Claude Code setup; drop misinformed CLI warning

#192 replaced the Claude Code copy/paste command with a hand-edit-this-JSON
blob plus a warning against `claude mcp add --header`. That was a real UX
regression, and the security premise was wrong for THIS transport:

- The argv / macOS-unified-log exposure applies to **stdio** transports
  (a spawned `npx mcp-remote --header ...` child), NOT native **HTTP**
  transport — there is no spawned child carrying the header in argv. #143's
  threat model was conflated with the mcp-remote setup it was also removing.
- Cleartext-at-rest in ~/.claude.json / .mcp.json is identical whether the
  entry is added via the CLI or hand-edited, so "edit the file instead"
  bought no at-rest improvement either.

(Confirmed against current Claude Code docs via claude-code-guide.)

Restores the single `claude mcp add --transport http ...` command as the
Claude Code path in the Settings UI, README, and the issue-32 template.
Removes the inaccurate warning and its now-dead `.mcp-security-warning` CSS
and the eslint-disable it required.

Kept from #192 (those parts were legit): native HTTP transport over the
deprecated mcp-remote, and the self-signed-cert / NODE_EXTRA_CA_CERTS
trust docs.

ADR-104's context has a passing line calling the `--header` form
deprecated; left as-is (accepted ADRs are immutable records of what we
believed then) — this commit is the corrective record.

2026-05-18 21:43:28 -05:00

1.8 KiB

Raw Permalink Blame History

Security Policy

Reporting Security Vulnerabilities

We take security seriously. If you discover a security vulnerability, please:

DO NOT open a public issue
DO report it via GitHub Security Advisories: Report a vulnerability
OR email details to the maintainer (check commit history for email)

What to Include

Description of the vulnerability
Steps to reproduce
Potential impact
Suggested fix (if any)

Known Security Issues

We're actively working on fixing these security vulnerabilities:

Issue	Status	Priority
No authentication on MCP server	✅ Done	CRITICAL
Path traversal in file operations	📋 Planned	CRITICAL
Missing input validation	📋 Planned	HIGH
Insecure session management	📋 Planned	HIGH

See our security issues for details.

Security Best Practices

Until security improvements are complete:

Only use on trusted networks (localhost only)
Don't expose the MCP port to the internet
Monitor vault access for unexpected changes
Keep backups of your vault
Review plugin permissions in Obsidian

Secure Configuration

{
  "httpEnabled": true,
  "httpPort": 3001,  // Change from default
  "autoDetectPortConflicts": true,
  "debugLogging": false  // Disable in production
}

Future Security Enhancements

API key authentication
Path validation framework
Input sanitization
Rate limiting
Audit logging
Encrypted sessions

Acknowledgments

Thanks to security researchers who responsibly disclose vulnerabilities.

1.8 KiB Raw Permalink Blame History