obsidian-plugin/firstsun-dev_git-files-sync
1
0
Fork 0
mirror of https://github.com/firstsun-dev/git-files-sync.git synced 2026-07-22 17:20:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
firstsun-dev_git-files-sync/session-handoff.md
ClaudiaFang 4fb27854fa chore: update harness state for GraphQL push + post-push status fix 
Records feat-014 (GitHub GraphQL batch push/delete, commit 114a575) and
feat-015 (avoid stale remote-tree read after push, commit 7676325) as
done. Also archived feat-011/012/013 and other completed narratives out
of progress.md (had grown past its own 80-line cleanup threshold) into
archive/2026-07.md, and trimmed feature_list.json evidence strings under
300 chars — harness self-audit was 96/100, now 100/100.
2026-07-14 11:54:32 +00:00

5 KiB
Raw Blame History

Session Handoff

Current Objective

  • Two fixes this session, both committed onto claude/fix-directory-symlink-pull-260713 (PR #51), not yet pushed to remote:
    1. feat-014 (commit 114a575): GitHub's pushBatch/deleteBatch switched from the REST Git Data API's per-file blob-creation loop to a single GraphQL createCommitOnBranch mutation.
    2. feat-015 (commit 7676325): fixed a false "modified" status shown right after a batch push, caused by re-fetching the remote tree too soon after a write (GitHub's tree-by-branch-name read can lag a moment behind a just-completed commit).

Completed This Session

  • githubGraphQL() helper in github-service.ts; explicit handling for GraphQL's 200-status-with-errors-array failure mode.
  • BaseGitService.getLatestCommitSha() extracted from resolveGitHubStyleBaseTree().
  • SyncManager.pushAllFiles() now returns syncedPaths: Array<{path, sha?}>, populated at all three push-success sites (batch chunk, sequential fallback, immediate symlink/rename push).
  • SyncStatusView.executeBatchOperation() marks just-pushed paths 'synced' directly via a new applyOptimisticSyncedStatus() instead of calling refreshAllStatuses() after a push. Pull is unchanged (still does a full refresh).
  • Live-verified both fixes against a real GitHub repo (firstsun-dev/obsidian-sync-test) using a scratchpad script that bundles the actual github-service.ts with a thin obsidian stub (requestUrl backed by real fetch) — not just mocks.
  • Filed issue #57 on firstsun-dev/git-files-sync (Project #6, P2, 4h): build a repeatable live-credential smoke test process across GitHub/GitLab/Gitea (this session only covered GitHub).
  • Cleaned up harness state: archived feat-011/012/013 + issue #78 fix + status-badge UI work into archive/2026-07.md (progress.md had grown past its own 80-line cleanup threshold); trimmed feature_list.json evidence strings under 300 chars. Harness self-audit went from 96/100 to 100/100.

Verification Evidence

Check Command Result Notes
Lint npx eslint . 0 errors
Type check + compat npm run build Pass Includes Obsidian 1.11.0 compat typecheck
Tests npx vitest run 344/344 passed +3 new: 2 for syncedPaths, 1 more for the post-push status behavior (total 5 new across both fixes)
Live smoke test ad-hoc scratchpad scripts Pass feat-014: pushBatch/deleteBatch each produced one commit with correct content. feat-015: single empty file and two-identical-empty-file batches both wrote correct 0-byte blobs with matching git shas — confirmed the bug was read-side (tree fetch timing), not write-side
Manual (in Obsidian) — Not done No Obsidian instance available in this environment

Files Changed (this session)

  • feat-014: src/services/github-service.ts, src/services/git-service-base.ts, tests/services/github-service.test.ts
  • feat-015: src/logic/sync-manager.ts, src/ui/SyncStatusView.ts, tests/logic/sync-manager-batch.test.ts, tests/ui/SyncStatusView.test.ts
  • Harness state: progress.md, session-handoff.md, feature_list.json, archive/2026-07.md

Decisions Made

  • GraphQL only for GitHub: GitLab's Commits API already sends a whole batch in one call; Gitea has no GraphQL API. GitServiceInterface stays REST-based elsewhere.
  • Optimistic local status update over re-fetching (feat-015): use data already known from the push itself rather than trusting an immediate remote read, which sidesteps GitHub's eventual-consistency window rather than just narrowing it with a delay/retry.
  • Credential handling: PATs must go into a scratchpad file the agent reads directly (fs.readFileSync), never typed as a !-prefixed command (still lands in the transcript) or passed as a Bash command-line argument (blocked by the permission classifier as credential materialization). Filed issue #57 to formalize this as the only documented path for future provider testing.

Blockers / Risks

  • Commits 114a575 and 7676325 are local only — not pushed to origin/claude/fix-directory-symlink-pull-260713 yet. Confirm with the user before pushing.
  • PR #51 keeps growing (10+ issues' worth now) — still worth flagging before adding more.

Next Session Startup

  1. Read CLAUDE.md, feature_list.json, progress.md, then this file.
  2. Run ./init.sh before editing.
  3. Check whether 114a575/7676325 have been pushed yet (git log origin/claude/fix-directory-symlink-pull-260713..HEAD); push first if not, after confirming with the user.

Recommended Next Step

  • Push this session's two commits, then either re-sync gh issue list or move to issue #37 (Bitbucket provider support) per the previously agreed order.