obsidian-plugin/hyungyunlim_obsidian-naver-blog-importer
1
0
Fork 0
mirror of https://github.com/hyungyunlim/obsidian-naver-blog-importer.git synced 2026-07-22 06:45:11 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
hyungyunlim_obsidian-naver-.../pr-apology-comment.md
hyungyunlim 1c619e8609 fix: address additional PR #7091 review feedback 
Resolve all remaining issues from ObsidianReviewBot review:

**Empty Block Statements:**
- Add meaningful comments to all empty catch blocks
- Properly handle error cases in image service, blog service, and API clients
- Remove unused error parameters where appropriate

**UI Text Improvements:**
- Remove all remaining emojis from Notice messages
- Ensure consistent sentence case across all user-facing text
- Clean up messages in main.ts, single-post-modal.ts, and settings-tab.ts

**Code Quality:**
- Fix empty catch blocks in naver-blog-fetcher.ts (3 locations)
- Fix empty catch blocks in image-service.ts (2 locations)
- Fix empty catch blocks in all API clients (openai, anthropic, google)
- Fix empty catch block in blog-service.ts
- Fix empty catch block in settings-tab.ts

All changes tested and build passes successfully.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-06 18:14:13 +09:00

1.1 KiB
Raw Permalink Blame History

Hi @Zachatoo,

I sincerely apologize for the oversight. You're absolutely right - I misunderstood your feedback and kept using (cancelNotice as any).messageEl when you clearly requested just cancelNotice.messageEl.

I've now properly fixed it in v1.2.4:

// @ts-ignore - accessing private messageEl property as suggested by Obsidian team
const messageEl = cancelNotice.messageEl;

You were very clear in your original feedback, and I should have implemented it exactly as you suggested. I apologize for not reading your feedback carefully enough.

✅ Fixed in v1.2.4

  • Removed as any casting - Now using cancelNotice.messageEl directly
  • Added @ts-ignore - To suppress TypeScript's complaint about the private property
  • Exact implementation - Following your specific guidance

Release: 1.2.4

Thank you for your patience and for taking the time to clarify. I really appreciate your thorough review, and I'll make sure to read feedback more carefully in the future.