obsidian-plugin/hyungyunlim_obsidian-naver-blog-importer
1
0
Fork 0
mirror of https://github.com/hyungyunlim/obsidian-naver-blog-importer.git synced 2026-07-22 06:45:11 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
hyungyunlim_obsidian-naver-.../pr-review-response.md
hyungyunlim 1c619e8609 fix: address additional PR #7091 review feedback 
Resolve all remaining issues from ObsidianReviewBot review:

**Empty Block Statements:**
- Add meaningful comments to all empty catch blocks
- Properly handle error cases in image service, blog service, and API clients
- Remove unused error parameters where appropriate

**UI Text Improvements:**
- Remove all remaining emojis from Notice messages
- Ensure consistent sentence case across all user-facing text
- Clean up messages in main.ts, single-post-modal.ts, and settings-tab.ts

**Code Quality:**
- Fix empty catch blocks in naver-blog-fetcher.ts (3 locations)
- Fix empty catch blocks in image-service.ts (2 locations)
- Fix empty catch blocks in all API clients (openai, anthropic, google)
- Fix empty catch block in blog-service.ts
- Fix empty catch block in settings-tab.ts

All changes tested and build passes successfully.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-06 18:14:13 +09:00

1 KiB
Raw Permalink Blame History

Thank you for the detailed review feedback! I've addressed all the issues identified by the ObsidianReviewBot:

Changes Made

✅ Type Safety

  • Replaced all any types with proper TypeScript types from cheerio and domhandler packages
  • Created BlogComponent interface for better type checking
  • All type errors resolved and build passes successfully

✅ Promise Handling

  • Added void operator to all unawaited promises:
    • refreshModels() background calls
    • saveSettings() calls in folder dropdown callbacks
    • syncSubscribedBlogs() async call
  • Removed unused error parameters in catch blocks

✅ Code Quality

  • Added braces {} to all case blocks with lexical declarations in switch statements
  • Fixed lexical scoping issues in both main.ts and settings-tab.ts

✅ UI Polish

  • Removed emojis from Notice messages for cleaner, more professional output

All changes have been committed and the build passes with no errors. Ready for the next review!

Commit: 71ef365 - "fix: address PR #7091 review feedback"