perf: empty containerEl on tab hide instead on display beginning

Thus, it ensure there is no persist and remain unused element in the background.
This commit is contained in:
kotaindah55 2025-03-20 20:54:16 +02:00
parent cf7906e851
commit af3c3c05da

View file

@ -41,7 +41,6 @@ export class ExtendedSettingTab extends PluginSettingTab {
display(): void {
let { containerEl } = this,
{ settings } = this.plugin;
containerEl.empty();
let settingsUIConfig = retrieveSettingUIConfigs(settings);
this.drawFromConfig(settingsUIConfig, containerEl);
this.isHidden = false;
@ -56,6 +55,7 @@ export class ExtendedSettingTab extends PluginSettingTab {
this.refreshInternal = this.rebuildColorStyleRules = false;
this.emptyTagSettingItems();
this.isHidden = true;
this.containerEl.empty();
super.hide();
}
emptyTagSettingItems() {