Commit graph

984 commits

Author SHA1 Message Date
Research Assistant
bbd910c0f2 fix: use rectEl instead of targetEl in delete handler 2026-05-20 19:08:02 +08:00
Research Assistant
6d2d761a31 fix: remove rect directly on delete, add rect directly on create 2026-05-20 19:06:51 +08:00
Research Assistant
51cc0fb0c4 fix: remove all overlays before rebuild in refresh 2026-05-20 19:01:19 +08:00
Research Assistant
a51de06330 diag: add viewBox probe for page 6 annotation 2026-05-20 18:54:57 +08:00
Research Assistant
774786d8ae fix: remove stray bracket, use viewport viewBox for dimensions 2026-05-20 18:52:05 +08:00
Research Assistant
9ee3c7b83a diag: add computed style probe 2026-05-20 18:45:59 +08:00
Research Assistant
0592aa44c1 diag: add DOM verification and test rect to rebuild path 2026-05-20 18:43:52 +08:00
Research Assistant
9062113a82 fix: use handle path in refresh when available 2026-05-20 18:42:20 +08:00
Research Assistant
492c87ac9b fix: refresh path uses DOM pages with setLayerDimensions alignment 2026-05-20 18:41:21 +08:00
Research Assistant
16a24cb14c debug: add rebuild visible layers counter log 2026-05-20 18:39:15 +08:00
Research Assistant
f6ac93859b fix: clean up dangling catch ghost code, add handle diagnostic log 2026-05-20 18:38:23 +08:00
Research Assistant
6618824253 fix: refresh overlays via _rebuildVisibleLayers on create/delete 2026-05-20 18:35:06 +08:00
Research Assistant
b228f4d472 fix: color swatch click creates annotation, overlay cleanup on file switch 2026-05-20 18:32:53 +08:00
Research Assistant
6642306262 feat: color picker, selection-to-create PDF coords, pypdf import guard 2026-05-20 18:31:02 +08:00
Research Assistant
489b29ff24 feat: overlay visible, fix popover dismiss, clean up debug code 2026-05-20 18:22:11 +08:00
Research Assistant
b7133b7ada feat: drive overlay repaint from PDF viewer events with internal handle resolution 2026-05-20 18:15:42 +08:00
Research Assistant
1b79c369ca feat: add PDF.js internal overlay guards and tests 2026-05-20 18:14:32 +08:00
Research Assistant
262541598f test: lock annotation cache and viewport helper contracts 2026-05-20 18:13:32 +08:00
Research Assistant
918e96f2c1 fix: use exact PDF page sizes for overlay mapping 2026-05-20 17:50:28 +08:00
Research Assistant
97b777ab8b fix: use PDF page dimensions for coordinate normalization 2026-05-20 17:11:45 +08:00
Research Assistant
a278637673 fix: use full field name in build_cache grouping 2026-05-20 17:07:39 +08:00
Research Assistant
8800a3c8b3 fix: use full field names in annotation cache, render only on new page 2026-05-20 17:05:41 +08:00
Research Assistant
d5e7b2a5be fix: debounce page observer to prevent render spam 2026-05-20 17:03:50 +08:00
Research Assistant
bbf34f22f7 fix: match cache pos key instead of position_json 2026-05-20 17:03:27 +08:00
Research Assistant
7068b38d26 fix: add missing _annotationCache declaration and match by attachmentKey 2026-05-20 17:01:46 +08:00
Research Assistant
f5a7bf3469 feat: JSON annotation cache for plugin (no subprocess on reads) 2026-05-20 17:00:34 +08:00
Research Assistant
723e5fc5a4 fix: inline AnnotationDB class, remove local require 2026-05-20 16:55:19 +08:00
Research Assistant
1aa2b26837 refactor: use sql.js instead of subprocess for annotation reads 2026-05-20 16:53:53 +08:00
Research Assistant
e5f0c1f956 fix: extract annotations array from data envelope, add --pdf-path to create 2026-05-20 16:42:59 +08:00
Research Assistant
e809722a03 fix: correct annotation overlay coordinate normalization and pdf-path resolution 2026-05-20 16:27:00 +08:00
Research Assistant
e66e7ed2d3 feat: add local annotation editing 2026-05-20 16:02:44 +08:00
Research Assistant
8e63f72847 feat: render annotation overlays 2026-05-20 16:00:51 +08:00
Research Assistant
d399a8838d feat: add pdf overlay patch lifecycle 2026-05-20 15:59:24 +08:00
Research Assistant
06e6485e46 feat: add annotation plugin bridge 2026-05-20 15:57:31 +08:00
Research Assistant
7692149705 feat: add annotation plugin helpers 2026-05-20 15:56:09 +08:00
Research Assistant
2aea1150d2 test: verify annotation persistence across memory rebuild
- TestMemoryRebuildSurvival proves annotations in annotations.db survive
  a full memory layer drop_all_tables + rebuild cycle, because the two
  databases are independent
2026-05-20 15:51:53 +08:00
Research Assistant
d2bfed9d12 feat: add annotation cli commands
- paperforge/cli.py                   adds annotation subparser with 7 subcommands
- paperforge/commands/annotation.py   dispatch + command implementations
  - import/list/create/patch/delete/export/status
  - all support --json output via PFResult envelope
- tests/cli/test_annotation_commands.py  10 tests: parser validation + integration
  create/list/patch/delete lifecycle
2026-05-20 15:51:32 +08:00
Research Assistant
f880d50092 feat: add annotation service
- paperforge/annotation/service.py  create/patch/delete/list/get/export
  - create_annotation()          local annotation with UUID
  - patch_annotation()           comment/color/tags only, enforces readonly guard
  - delete_annotation()          soft delete
  - get_annotation()             single row lookup
  - list_annotations()           filtered by paper/page/type
  - export_annotations_json()    JSON serialization
  - export_annotations_markdown() Markdown serialization
- tests/unit/annotation/test_service.py  11 tests: create, patch, readonly
  enforcement, soft/hard delete, list filtering, JSON/MD export
2026-05-20 15:48:20 +08:00
Research Assistant
ed869dffaa test: add fixture-driven annotation import coverage
- fixtures/zotero/build_test_db.py  generates minimal Zotero SQLite with
  highlight/underline/note annotations and tags
- tests/integration/test_annotation_import_workflow.py  end-to-end probe→import→verify
  pipeline using a real SQLite fixture (generated on demand, not checked in)
- .gitignore  excludes generated *.sqlite from fixtures/zotero
2026-05-20 15:47:13 +08:00
Research Assistant
c708e00184 feat: add annotation import reconciliation
- paperforge/annotation/importer.py  stable upsert by id, version tracking,
  soft-delete of stale rows, cross-source isolation
- paperforge/annotation/service.py   mark_deleted, hard_delete, list
- tests/unit/annotation/test_importer.py  5 tests: import, noop, update,
  soft-delete, source isolation
2026-05-20 15:46:06 +08:00
Research Assistant
85918eba14 feat: add zotero annotation probe
- paperforge/annotation/probe.py  read-only Zotero SQLite query layer
  - open_readonly()              URI mode=ro connection
  - copy_db_to_temp()            safe copy before reading
  - fetch_annotations()          SQL JOIN across items/itemAnnotations/itemAttachments
  - _fetch_tags()                tag aggregation
  - normalize_annotation_row()   type mapping + position JSON parsing
- tests/unit/annotation/test_probe.py  fixture-driven tests with minimal Zotero DB
2026-05-20 15:45:11 +08:00
Research Assistant
0efd6c83f6 feat: add annotation schema
- paperforge/annotation/schema.py  DDL, indexes, FTS5, sync_queue, version lifecycle
- ANNOTATIONS_SCHEMA_VERSION = 1, independent from memory layer
- FTS triggers on insert/update/delete for selected_text + comment + tags_json
- Schema is never dropped during memory rebuild
2026-05-20 15:43:14 +08:00
Research Assistant
771fff0111 feat: add annotation db helpers
- paperforge/annotation/__init__.py  package marker
- paperforge/annotation/db.py        path resolution and connection helpers
  (get_annotations_db_path, get_annotations_connection)
- tests/unit/annotation/test_schema.py  DB path, WAL, read-only tests
2026-05-20 15:41:18 +08:00
Research Assistant
3729381fd5 feat: add hardcoded-path audit gate with pre-commit hook
- New tests/audit/test_hardcoded_paths.py detects config-driven path
  literals hardcoded in Python source files
- Pre-commit hook runs the audit automatically before every commit
- Fixed three existing violations:
  paperforge/commands/sync.py    -> use paperforge_paths()
  paperforge/commands/dashboard.py -> use paperforge_paths()
  paperforge/worker/discussion.py  -> use paths.get('index')
2026-05-20 15:39:21 +08:00
Research Assistant
3c270c6932 docs: add pdf annotation layer design spec and implementation plan 2026-05-20 15:33:13 +08:00
Research Assistant
63c6be3f78 feat(skill): add version field to SKILL.md frontmatter and bootstrap, with pre-flight version check 2026-05-19 15:54:04 +08:00
Research Assistant
7c4f5b4bb0 docs: update AGENTS.md with skill graph structure, intent routing, bump/release, and skill deploy 2026-05-19 15:47:53 +08:00
Research Assistant
946102bb9e bump: 1.5.8 -> 1.5.9 2026-05-19 15:44:52 +08:00
Research Assistant
cf4d929a24 fix(skill): add multi-intent collision rule to intent routing 2026-05-19 15:40:33 +08:00
Research Assistant
c21fc8db1e chore: remove temp test file 2026-05-19 15:28:43 +08:00